michaelkuc6/blog_os
1
0
Fork 0
mirror of https://github.com/phil-opp/blog_os.git synced 2025-12-16 14:27:49 +00:00
Code Issues Projects Releases Wiki Activity

Add rsi to the clobber list (#195)

Browse Source 
In the second macro (handler_with_error_code), we pop the error code into rsi, this means we are changing the value of rsi in the assembly block, so we should add it to the clobbers.

I am quite new to this, so please close this request if I am completely wrong.

(Side question: An other thing I came across while trying to figure out if this was correct, is that every documentation says you should add curly brackets around register names, can someone tell me why this is not done here?)
This commit is contained in:
Leon Loopik
2016-08-04 00:19:12 +02:00
committed by Philipp Oppermann
parent 5e6a8cb69b
commit ca925c49e0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
blog/post/2016-08-03-better-exception-messages.md
View File

@@ -509,7 +509,7 @@ macro_rules! handler_with_error_code {
call $0" call $0"
:: "i"($name as extern "C" fn( :: "i"($name as extern "C" fn(
*const ExceptionStackFrame, u64) -> !) *const ExceptionStackFrame, u64) -> !)
: "rdi" : "intel"); : "rdi,rsi" : "intel");
::core::intrinsics::unreachable(); ::core::intrinsics::unreachable();
} }
} }