michaelkuc6/blog_os
1
0
Fork 0
mirror of https://github.com/phil-opp/blog_os.git synced 2025-12-16 14:27:49 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1116 from phil-opp/fix-comment-threads

Browse Source 
Move comment threads for translated posts to separate category
This commit is contained in:
Philipp Oppermann
2022-06-07 10:08:13 +02:00
committed by GitHub
parent 1c9b5edd6a b05c07d21c
commit 2eb5147675
5 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
blog/templates/edition-2/extra.html
View File

@@ -17,6 +17,6 @@
<hr> <hr>
<section> <section>
<h2 id="comments">Comments</h2> <h2 id="comments">Comments</h2>
{{ snippets::giscus(search_term=page.title ~ " (Extra Post)") }} {{ snippets::giscus(search_term=page.title ~ " (Extra Post)", translated=false) }}
</section> </section>
{% endblock after_main %} {% endblock after_main %}

7
blog/templates/edition-2/page.html
View File

@@ -118,7 +118,12 @@
{% else %} {% else %}
{% set search_term=page.title %} {% set search_term=page.title %}
{% endif %} {% endif %}
{{ snippets::giscus(search_term=search_term) }} {% if page.lang != "en" %}
{% set translated = true %}
{% else %}
{% set translated = false %}
{% endif %}
{{ snippets::giscus(search_term=search_term, translated=translated) }}
{%- if page.lang != "en" %} {%- if page.lang != "en" %}
<p class="{% if page.extra.rtl %}right-to-left{% endif %}"> <p class="{% if page.extra.rtl %}right-to-left{% endif %}">

2
blog/templates/news-page.html
View File

@@ -17,7 +17,7 @@
<hr> <hr>
<section> <section>
<h2 id="comments">Comments</h2> <h2 id="comments">Comments</h2>
{{ snippets::giscus(search_term=page.title ~ " (News Post)") }} {{ snippets::giscus(search_term=page.title ~ " (News Post)", translated=false) }}
</section> </section>
{% endblock after_main %} {% endblock after_main %}

14
blog/templates/snippets.html
View File

@@ -10,12 +10,20 @@
</p> </p>
{% endmacro support %} {% endmacro support %}
{% macro giscus(search_term) %} {% macro giscus(search_term, translated) %}
{% if translated %}
{% set category = "Post Comments" %}
{% set category_path = "post-comments" %}
{% else %}
{% set category = "Post Comments (translated)" %}
{% set category_path = "post-comments-translated" %}
{% endif %}
{% if search_term is number %} {% if search_term is number %}
{% set discussion_url = "https://github.com/phil-opp/blog_os/discussions/" ~ search_term %} {% set discussion_url = "https://github.com/phil-opp/blog_os/discussions/" ~ search_term %}
{% else %} {% else %}
{% set search_term_encoded = `"` ~ search_term ~ `"` | urlencode %} {% set search_term_encoded = `"` ~ search_term ~ `"` | urlencode %}
{% set discussion_url = `https://github.com/phil-opp/blog_os/discussions/categories/post-comments?discussions_q=` ~ search_term_encoded %} {% set discussion_url = `https://github.com/phil-opp/blog_os/discussions/categories/` ~ category_path ~ `?discussions_q=` ~ search_term_encoded %}
{% endif %} {% endif %}
<p class="comment-note"> <p class="comment-note">
@@ -27,7 +35,7 @@
<script src="https://giscus.app/client.js" <script src="https://giscus.app/client.js"
data-repo="phil-opp/blog_os" data-repo="phil-opp/blog_os"
data-repo-id="MDEwOlJlcG9zaXRvcnkzOTU3NTEwMQ==" data-repo-id="MDEwOlJlcG9zaXRvcnkzOTU3NTEwMQ=="
data-category="Post Comments" data-category="{{ category }}"
data-category-id="MDE4OkRpc2N1c3Npb25DYXRlZ29yeTMzMDE4OTg1" data-category-id="MDE4OkRpc2N1c3Npb25DYXRlZ29yeTMzMDE4OTg1"
{% if search_term is number %} {% if search_term is number %}
data-mapping="number" data-mapping="number"

2
blog/templates/status-update-page.html
View File

@@ -32,7 +32,7 @@
<hr> <hr>
<section> <section>
<h2 id="comments">Comments</h2> <h2 id="comments">Comments</h2>
{{ snippets::giscus(search_term=page.title) }} {{ snippets::giscus(search_term=page.title, translated=false) }}
</section> </section>
{% endblock after_main %} {% endblock after_main %}